fix issue 1968#1975
Merged
ryanjbaxter merged 1 commit intospring-cloud:3.2.xfrom Aug 12, 2025
wind57:fix-1968-close-fabric8-client
Merged
fix issue 1968#1975ryanjbaxter merged 1 commit intospring-cloud:3.2.xfrom wind57:fix-1968-close-fabric8-client
ryanjbaxter merged 1 commit intospring-cloud:3.2.xfrom
wind57:fix-1968-close-fabric8-client
Conversation
wind57
commented
Aug 12, 2025
| return new Fabric8PodUtils(client); | ||
| } | ||
|
|
||
| @EventListener |
Contributor
Author
There was a problem hiding this comment.
so after reviewing the history a bit, we only did this because of a failure in an integration test.
Since then, we refactored integration tests a lot and cleaned up the code. I see no errors now in this build, it passes.
Also, to be honest, I would drop this code (because it impacts leader election) and review again, if we ever have the same problem.
Contributor
Author
|
@ryanjbaxter this is ready to be looked at, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.