close shared informers + minor cleanup in tests#2122
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Jan 21, 2026
Merged
close shared informers + minor cleanup in tests#2122ryanjbaxter merged 1 commit intospring-cloud:mainfrom
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
Conversation
Contributor
Author
|
@ryanjbaxter ready to be looked at. thank you |
wind57
commented
Jan 21, 2026
| @@ -40,37 +40,33 @@ class KubernetesClientCatalogWatchAutoConfigurationApplicationContextTests { | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
from here and below, all that is done is to remove : spring.cloud.config.enabled=false
Contributor
|
Thanks! As you have probably noticed I have been making a lot of changes for the github action. We have a goal of moving solely to github actions over the coming months so I have been experimenting with k8s. I THINK I have things in a good state, but let me know if you notice anything weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.