Quote '?' in Quoted Printable filename#30252
Closed
luozhenyu wants to merge 1 commit into
Closed
Conversation
d08cbc6 to
6438ad8
Compare
6438ad8 to
84117e8
Compare
rstoyanchev
reviewed
Apr 17, 2023
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
This seems related to the recent change in #29861 and the added regular "filename" parameter. Prior to that for filename(..., UTF_8) we created only a "filename*" parameter via encodeRfc5987Filename, and that part of the test works.
poutsma
added a commit
that referenced
this pull request
Apr 18, 2023
This commit polishes an external contribution, ensuring that not just spaces are encoded as underscores, and that underscores are encoded as non-printable. See gh-30252
poutsma
added a commit
that referenced
this pull request
Apr 18, 2023
* gh-30252: Polish contribution Quote question marks in content-disposition
Contributor
|
Thank you for submitting a PR. I have made a couple of changes also related to RFC 2047, so that spaces are now encoded as underscores, and that underscores themselves are handled as non-printable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bad case
Cause
In previous implementation, the question mark (?) is not quoted. If a quoted character (=E9=97=AE) follows, the combination "?=" will be interpreted as end mark of "encoded-word".