Remove compiler warnings in spring-security-ldap #18559
Open
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add compile-warnings-error plugin to ldap module - Replace org.springframework.lang.NonNull with org.jspecify.annotations.NonNull - Add @SuppressWarnings for unchecked/rawtypes/deprecation warnings Closes spring-projectsgh-18405 Signed-off-by: LeeJiWon <dlwldnjs1009@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: build
rwinch
added
the
status: waiting-for-feedback
Add new constructor accepting PasswordEncoder to eventually remove deprecated LdapShaPasswordEncoder usage. Closes spring-projectsgh-18430 Signed-off-by: LeeJiWon <dlwldnjs1009@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
compile-warnings-errorplugin to thespring-security-ldapmoduleorg.springframework.lang.NonNullwithorg.jspecify.annotations.NonNull@SuppressWarningsfor unchecked / rawtypes / deprecation warningsPasswordComparisonAuthenticatorconstructorand introduce a new constructor accepting
PasswordEncoderto prepare forremoval of deprecated
LdapShaPasswordEncoderusageTest plan
./gradlew --no-build-cache clean :spring-security-ldap:check./gradlew format && ./gradlew checkCloses gh-18430