Factor out static methods for Spring Data repository completions#983
Closed
danthe1st wants to merge 1 commit intospring-projects:mainfrom
Closed
Factor out static methods for Spring Data repository completions#983danthe1st wants to merge 1 commit intospring-projects:mainfrom
danthe1st wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
|
Merged with 64fabdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out Spring Data repository completions into multiple classes as suggested in #981 (comment).
Instances of these classes are stored in a
Listwhich is instantiated in the constructor ofDataRepositoryCompletionProcessor.For now, I have not used Spring Beans for this as it seems that only the package
org.springframework.ide.vscode.boot.appis scanned for components.Alternatively, corresponding Spring beans could be defined in
BootJavaCompletionEngineConfigureror similar.This PR should not change any functionality.