Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

PR: Update with Palantir's 0.26 version#12

Merged
goanpeca merged 5 commits intospyder-ide:developfrom
goanpeca:update2
Mar 27, 2019
Merged

PR: Update with Palantir's 0.26 version#12
goanpeca merged 5 commits intospyder-ide:developfrom
goanpeca:update2

Conversation

@goanpeca
Copy link
Copy Markdown

Update with latest palantir

Cynerd and others added 5 commits March 27, 2019 08:57
`Config.settings()` takes a few milliseconds to run and reads config files from disk. This function runs multiple times during initialization and before every linting request. This means we can very effectively cache the results.

This PR uses `lru_cache` to cache the the result of `Config.settings()`. The cache is invalidated when the config is updated or a config file is changed.

Fixes palantir#305
Fixes palantir#515 
Fixes palantir#526 

Also only generates snippets for positional args
@goanpeca goanpeca requested a review from ccordoba12 March 27, 2019 21:40
@goanpeca goanpeca merged commit cd172d3 into spyder-ide:develop Mar 27, 2019
@goanpeca goanpeca deleted the update2 branch March 27, 2019 21:43
@ccordoba12 ccordoba12 added this to the v0.90 milestone Mar 28, 2019
@ccordoba12 ccordoba12 changed the title PR: Update2 PR: Update with Palantir's 0.26 version Mar 28, 2019
include_params = settings.get('include_params', True)
should_include_params = settings.get('include_params')

log.debug('Finish Jedi!!!')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca, you have to be more careful with your merges. You're removing lines that I've added before (like this one).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And @steff456 added the same line before me.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will do!

steff456 pushed a commit to steff456/spyder-pyls that referenced this pull request Aug 3, 2020
Add '--follow-imports silent' to mypy invocation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants