Skip to content

Conversation

@424ever
Copy link

@424ever 424ever commented Jan 5, 2026

The IRC Server of osu! sends QUIT messages that are terminated with \n instead of \r\n, which causes parsing to fail.

@casperstorm casperstorm requested a review from tarkah January 6, 2026 10:07
@424ever
Copy link
Author

424ever commented Jan 9, 2026

I think the splitting in codec.rs doesn't quite work how I wrote it, I'll change it later today

@tarkah
Copy link
Member

tarkah commented Jan 12, 2026

Irc docs specifically state use of cr/lf, not lf on it's own.

https://modern.ircdocs.horse/#message-format

I'm afraid of the unintended consequences this change would cause. Why does this server not use carriage return?

@424ever
Copy link
Author

424ever commented Jan 16, 2026

I'm afraid of the unintended consequences this change would cause.

I understand that this doesn't follow the specification, but since this pattern being supported by most irc implementations I've checked, I suspect it wouldn't cause any issues.

As seen in the node-irc pr, rfc1459 also recommends splitting messages on different line endings instead of requiring CR-LF.

Why does this server not use carriage return?

This server is primarily used as the in-game chat, and the lead developer has previously said that adhering to the specification and supporting specific clients is not a priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants