create a shared text wrapper to always add line_height from config#1466
Merged
casperstorm merged 3 commits intomainfrom Feb 12, 2026
Merged
create a shared text wrapper to always add line_height from config#1466casperstorm merged 3 commits intomainfrom
casperstorm merged 3 commits intomainfrom
Conversation
andymandias
approved these changes
Feb 12, 2026
Collaborator
andymandias
left a comment
andymandias
left a comment
There was a problem hiding this comment.
Haven't tested but looks good to me. Approach will need modification when font reload support is added, but we can cross that bridge when we come to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was planned for #1430 but i forgot it...
idea is just to have a shared
widget::textnow so we don't forget theline_heightmoving forward.