Open
Conversation
Owner
|
Hey, I'm really happy about this pull request, but i'm not actually the base fork. Can you submit this pull request to the revelytix branch? |
Author
|
Actually I have sent pull request to revelytix. But it seems they are not very active on this project. And I thought you might have token over the project ... Thank you. |
Owner
|
@sunng87, I'll write to the revelytix guys and see what I can do! We'll get this merged for you one way or another. I'll keep this open for now until we figure out how it'll get resolved. |
|
Did this happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi sritchie,
In this pull request, I made two major changes on carbonite:
read-stringandprnas serializer.