Perform references when reading collections & maps#4
Open
trptcolin wants to merge 1 commit intosritchie:masterfrom
Open
Perform references when reading collections & maps#4trptcolin wants to merge 1 commit intosritchie:masterfrom
trptcolin wants to merge 1 commit intosritchie:masterfrom
Conversation
Author
|
Welp, there's at least one more problem here when I run my real data, though this gets me further. I'll have to see if I can shrink it down to a reasonable test case. |
Author
|
Feel free to toss this PR out. Our performance after just defining But I am wondering if there's something inherently problematic about doing this with immutable data structures. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the stuff we talked about on twitter/IRC. Maps ended up more complex than I thought - possibly something wrong with Kryo, but it's hard to say. Without the custom reference resolver, the first map reference would get lost somehow - further nested ones seemed to work fine, the reference objects being read always seemed to fetch the second entry. And this was only with maps - vectors seemed to work fine, and seqs also didn't seem to need anything special.
So this gets all the tests passing that I could think of, but it's certainly possible there are cases I'm not thinking of. I did also hack around with test cases that complicated the nesting + repeating, but threw them away since they already seemed to work.