Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH#1229
Merged
WojciechNagorski merged 9 commits intodevelopfrom Nov 1, 2023
Merged
Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH#1229WojciechNagorski merged 9 commits intodevelopfrom
WojciechNagorski merged 9 commits intodevelopfrom
Conversation
Suppress all errors in unit tests and integration tests.
…row ArgumentException.
drieseng
changed the title
Rob-Hague
reviewed
Oct 30, 2023
Collaborator
Rob-Hague
left a comment
Rob-Hague
left a comment
There was a problem hiding this comment.
I still don't see any value in enabling analyzers just to add a bunch of suppressions in the source, but otherwise it is fine for me.
Rob-Hague
reviewed
Oct 31, 2023
Rob-Hague
approved these changes
Nov 1, 2023
Member
Author
|
@WojciechNagorski, can I also get your stamp of approval? |
WojciechNagorski
approved these changes
Nov 1, 2023
Collaborator
|
Build times and general responsiveness in VS have taken a massive hit. I beg that we reconsider 🥺 |
Member
Author
|
@Rob-Hague, I'm perfectly fine with disabling (some of) the analyzers by default. I'll submit a new PR to get the build in an acceptable state. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix analyzer errors in Renci.SshNet and Renci.SshNet.TestTools.OpenSSH.
Suppress all errors in unit tests and integration tests.