Updated NETCONF framing protocol detection to check both client & server capabilities#639
Merged
Rob-Hague merged 4 commits intosshnet:developfrom Jun 16, 2024
Merged
Conversation
…ver capabilities This fixes an issue where the NetConfSession would expect the framing protocol to be used if ServerCapabilities contained 1.1, however the server would actually be using the legacy protocol as the client only advertises support for 1.0.
Contributor
|
Please merge this |
Rob-Hague
added a commit
to schaveyt/SSH.NET
that referenced
this pull request
Dec 8, 2023
…ing_protocol Adding co-author credit from sshnet#639: Co-authored-by: Jason Larke <jason.larke@curtin.edu.au>
Rob-Hague
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
Rob-Hague
approved these changes
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the NetConfSession would expect the framing protocol to be used if ServerCapabilities contained 1.1, however the server would actually be using the legacy protocol as the client only advertises support for 1.0.
While SSH.NET claims to support the framing protocol, the implementation appears to be buggy / broken; advertising 1.1 support on the client-side is not advisable until that is investigated / fixed.
Fixes #405
Fixes #342
Fixes #1197