fix(ci): surface dockhand errors in Build Skill Artifacts step#516
Merged
Conversation
The `Build skill artifact` step captured dockhand's output with `output=$(/tmp/dockhand build-skill ... 2>&1)` and then `echo "$output"`. Under `set -e`, a dockhand failure exits the shell on the assignment line before `echo` runs, so the job log only shows `##[error]Process completed with exit code 1.` with no dockhand output. Stream output through `tee` to a tempfile so it's visible in the job log as dockhand runs, and enable pipefail so a dockhand failure still fails the step. Digest extraction reads the tempfile; `|| true` preserves the prior behavior where a missing `Digest:` line yields an empty digest (downstream steps already gate on `digest != ''`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🛡️ Skill Security Scan Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build skill artifactstep in.github/workflows/build-skills.ymlcaptured dockhand's combined output withoutput=\$(/tmp/dockhand build-skill ... 2>&1)and thenecho \"\$output\". Underset -e, a dockhand failure exits the shell on the assignment line beforeechoruns, so the only signal in the job log is##[error]Process completed with exit code 1.— the actual dockhand error is never printed.teeto a tempfile and enablepipefail, so output is visible in real time and a non-zero exit still fails the step.Behavior
steps.build.outputs.digest.|| trueon thegrep | awkpipeline; downstream steps already gate ondigest != ''.Test plan
Build Skill Artifactsviaworkflow_dispatch(or retrigger the failed runs for feat(skills): package 4 Google Gemini skills #502 / feat(skills): package 3 Neon skills #506) and confirm dockhand error text is visible in the job log.steps.build.outputs.digestand proceed through Cosign + attestation steps.🤖 Generated with Claude Code