Open
Conversation
Contributor
|
@barslev Winston 3 does introduce a number of breaking changes which is why we haven't upgraded it yet |
Author
|
@contra Thanks for your reply. I have went through all the breaking changes in winston and all the applicable ones should be covered by the pull request. I noticed that you previously reverted back from winston 3 to winston 2 due to pretty printing issues (42bf1e). The breaking change that you did not take into account was that winston removed formatting options from winston.transports.Console. The call to convertOptionsToWinstonV3 handles this breaking change. |
Contributor
|
@barslev Out of curiosity, are you using |
Author
|
@contra No, I'm not. This pull request is part of a research project about updating npm dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of the code indicates that no other parts are affected by the breaking changes in the library update.