Add vignette on how to handle deprecations with $format()#644
Add vignette on how to handle deprecations with $format()#644rok-cesnovar merged 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 92.63% 91.16% -1.47%
==========================================
Files 12 12
Lines 3406 3419 +13
==========================================
- Hits 3155 3117 -38
- Misses 251 302 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there a bug in the format method? I don't think it's actually overwriting the Stan file when mod$format(
canonicalize = list("deprecations"),
overwrite_file = TRUE,
backup = FALSE
)
mod$print()Then |
|
I think print() might use a stored string of the file? |
|
Yeah. I think we need to put the string of the new Stan code in |
|
Ok I think I fixed the printing issue. If that fix and my edits to the vignette look good to you then I think this is ready. |
|
Actually I think we also still need to do this part of #626:
|
Submission Checklist
Summary
Adds a vignette on handling deprecations with the canonicalizer available through the
$format()method.Online vignette can be seen here: https://rok-cesnovar.github.io/cmdstanr/articles/deprecations.html
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: