Bugfixes in .stanfunctions, hessian model method, and exposing RNG functions#811
Bugfixes in .stanfunctions, hessian model method, and exposing RNG functions#811
Conversation
Good idea, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 88.24% 86.58% -1.67%
==========================================
Files 12 12
Lines 4161 4175 +14
==========================================
- Hits 3672 3615 -57
- Misses 489 560 +71
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rok-cesnovar
left a comment
There was a problem hiding this comment.
Andrew is on a roll, I love it :)
|
Thanks @andrjohns! |
Submission Checklist
Summary
This PR comprises two small bugfixes:
.stanfunctionswas not treated as a valid extensionmath/mix.hppwas not included early enough, resulting in compilation errors for somehessianmodelsAnd one slightly larger bugfix in the handling of exposing RNG functions. Currently, we expose RNG functions with an integer
seedargument (default = 0) - such that users need to change thisseedargument if they want a different value on each call. This PR changes that behaviour to initialise a Boost RNG and store it in the functions environment, which is then passed to the exposed RNG function - allowing the exposed RNG function to act as expected.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: