Fix handling of single-length inits for containers#857
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 88.19% 88.20%
=======================================
Files 12 12
Lines 4218 4221 +3
=======================================
+ Hits 3720 3723 +3
Misses 498 498
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
@rok-cesnovar would you be able to have a look over this when you get a minute? It's a bugfix for #855 |
rok-cesnovar
approved these changes
Sep 27, 2023
Member
rok-cesnovar
left a comment
There was a problem hiding this comment.
Thanks, was a quick review :)
Collaborator
Author
|
Brilliant, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Resolves the bug report in #855, which identified a more general issue that passing initial values for single-element containers would fail due to the
auto_unboxsetting injsonlitetreating them as scalars, resulting incmdstanthrowing a dimension-mismatch error.This PR updates the processing of init-lists to check whether the initial value is for a single dimension-container and then format the value appropriately
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: