Rename integrate_ode to integrate_ode_rk45 and integrate_ode_cvode to integrate_ode_bdf

[syclik]

Summary:

For v2.10, we want to rename:

• integrate_ode to integrate_ode_rk45
• integrate_ode_cvode to integrate_ode_bdf

Additional Information:

The Stan library will need to change. See stan-dev/stan#1886.

Current Version:

v2.9.0

[betanalpha]

It should be "bdf", the standard acronym for "backwards differentiation formula".

On May 3, 2016, at 19:52, Daniel Lee notifications@github.com wrote:

Summary:

For v2.10, we want to rename:

integrate_ode to integrate_ode_rk45
integrate_ode_cvode to integrate_ode_bf
Additional Information:

The Stan library will need to change.

Current Version:

v2.9.0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

[syclik]

yeah... I caught it after I created the issues. They've all been fixed on
the two issues.

On Tue, May 3, 2016 at 3:15 PM, Michael Betancourt <notifications@github.com

wrote:

It should be "bdf", the standard acronym for "backwards differentiation
formula".

On May 3, 2016, at 19:52, Daniel Lee notifications@github.com wrote:

Summary:

For v2.10, we want to rename:

integrate_ode to integrate_ode_rk45
integrate_ode_cvode to integrate_ode_bf
Additional Information:

The Stan library will need to change.

Current Version:

v2.9.0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#292 (comment)

[wds15]

This is great.

@syclik : You could consider to make the test

math/test/unit/math/rev/arr/functor/integrate_ode_tooMuchWork_test.cpp

run a lot faster. In that test we check that the too much work exception is thrown inside the integrate_ode function. The test is time-consuming right now as I had no way to reduce the default 1E6 admissible steps. So just reducing that number to 10 within the test should make the test run a lot faster and do the same work for us.

Just a thought.

[bob-carpenter]

Is there a reason this isn't a pull request yet? I'm coding against it for the related Stan issue, which I won't be able to push until this is pushed.

[syclik]

No good reason. My first stab at it was wrong. I'll make it a pull request asap.

On May 12, 2016, at 1:05 PM, Bob Carpenter notifications@github.com wrote:

Is there a reason this isn't a pull request yet? I'm coding against it for the related Stan issue, which I won't be able to push until this is pushed.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[syclik]

Fixed with #293.