CVODES exceptions converted to domain_error

[WardBrian]

Summary

The errors we throw based on CVODES flags were sometimes std::runtime_errors, which we'd like to be able to use for other things (e.g. exit() in the language and other things which aren't recoverable).

This changes all of them to domain_error, which is what we use for other issues that could be resolved by changing the parameters and trying again.

I believe this should close #1039, which was already partially addressed by #2620

Tests

Side Effects

Release notes

Functions which are wrappers around CVODES and IDAS routines from Sundials now throw domain_error, rather than a mix of domain_error and runtime_error

Checklist

• Copyright holder: Simons Foundation

  The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
  - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
  - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

• the basic tests are passing

  • unit tests pass (to run, use: ./runTests.py test/unit)
  • header checks pass, (make test-headers)
  • dependencies checks pass, (make test-math-dependencies)
  • docs build, (make doxygen)
  • code passes the built in C++ standards checks (make cpplint)

• the code is written in idiomatic C++ and changes are documented in the doxygen

• the new changes are tested

[syclik]

LGTM!

[syclik]

@WardBrian, thanks! And yes, this should resolve #1039. This is definitely an improvement the current behavior.

(Maybe someone with deep CVODES expertise could separate out the different error conditions, but that could come later if it matters.)