Conversation
Member
|
There are several orders of magnitude more x86 windows users than ARM, so if we do test this at all we should do it in addition rather than as a replacement |
Collaborator
Author
Ah yeah true, will add both |
WardBrian
approved these changes
Apr 23, 2025
Member
|
It looks like sometimes these jobs get stuck installing rtools, e.g: https://github.com/stan-dev/math/actions/runs/14649317253/job/41111049475?pr=3171 1 hour and counting just in the install step |
Member
|
I can't tell if it's a rate limiting issue or the installer thats hanging. If its the former we could add an authorization header to Invoke-WebRequest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows ARM runners are now available for public repos, so we can add them to the CI. I've just replaced the existing windows runners, but can also add them separately if we want both x86-64 & arm64 rtools.
The
setup-raction doesn't support arm64, so I've just added a step to manually install RToolsTests
N/A - existing tests should still pass
Side Effects
N/A
Release notes
Added Windows ARM64 to the Github CI
Checklist
Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested