Add 6 and 8 argument overloads to wiener_lpdf#1411
Merged
Conversation
Scalar only for now, see #1373 for partial reason
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1411 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 63 63
Lines 10525 10529 +4
=======================================
+ Hits 9459 9463 +4
Misses 1066 1066
|
4 tasks
SteveBronder
approved these changes
Mar 19, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From stan-dev/math#2822
Scalar only for now, see #1373 for partial reason
I didn't add support for the optional
precision_derivativesargument both of these have in C++. These would need to bedata, which we don't currently support in the machinery for our distributions. We can add them manually or rethink this later.Submission Checklist
Release notes
Exposed the new overloads of
wiener_lpdfadded to Stan Math by @Franzi2114Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)