Skip to content

Add first Dutch translation#1947

Merged
jasonvarga merged 11 commits intostatamic:masterfrom
studio1902:master
Jul 2, 2020
Merged

Add first Dutch translation#1947
jasonvarga merged 11 commits intostatamic:masterfrom
studio1902:master

Conversation

@studio1902
Copy link
Copy Markdown

This is the first Dutch translation. I translated it without using v3 IRL but it should be a pretty solid basis. Will do additional PR's with bug fixes when I start using V3 more in the coming weeks.

Rob de Kort added 2 commits June 18, 2020 20:23
Copy link
Copy Markdown
Contributor

@ebeauchamps ebeauchamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nl.json, you will have to manually add (and translate) the following keys:
Create a Form
Create a Global Set
Create a Role
Create a Taxonomy
Create a User Group

Copy link
Copy Markdown
Contributor

@ebeauchamps ebeauchamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fieldtypes.php, you will have to manually add and translate:
textarea.config.character_limit
relationship.config.mode

You will have to check those fieldtypes in the English version of the CP to get the sentences that are to be translated.

@studio1902
Copy link
Copy Markdown
Author

Thanks @ebeauchamps. Fixed it. I’ve encountered some error’s with the CLI Translator tool at the end for one of the reviews. I think it was for fieldtypes.php. That might explain why those strings were missing.

Copy link
Copy Markdown

@plompd plompd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions

@ebeauchamps
Copy link
Copy Markdown
Contributor

@studio1902 An issue regarding my above comments was first reported in #1640

Missing keys were also reported in #1697 but you should check for the great work by @Konafets in #1904
Once his PR is merged, we should be able to get more keys to translate.

By the way, great work of yours here!

@jasonvarga jasonvarga merged commit f614ed6 into statamic:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants