Skip to content

Add config key to prevent glide from prepending the site root#1953

Closed
andjsch wants to merge 7 commits intostatamic:masterfrom
andjsch:master
Closed

Add config key to prevent glide from prepending the site root#1953
andjsch wants to merge 7 commits intostatamic:masterfrom
andjsch:master

Conversation

@andjsch
Copy link
Copy Markdown
Contributor

@andjsch andjsch commented Jun 18, 2020

This PR closes #1304

Copy link
Copy Markdown
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@andjsch
Copy link
Copy Markdown
Contributor Author

andjsch commented Jun 18, 2020

Alright, I did change everything to match your suggestions.

@wm-simon
Copy link
Copy Markdown

When in cms/config/assets.php the cache is set to true, the image urls are still prefixed.

@andjsch
Copy link
Copy Markdown
Contributor Author

andjsch commented Aug 20, 2020

Did you try clearing the cache after that? @Pfeifakopf

@wm-simon
Copy link
Copy Markdown

@AndreasSchantl Yes, i cleared the cache with optimize:clear and the image cache separately again. The paths are still wrong.

@andjsch
Copy link
Copy Markdown
Contributor Author

andjsch commented Aug 26, 2020

@jasonvarga might this be merged with 3.0.2?

@jonassiewertsen
Copy link
Copy Markdown
Contributor

Am uprading a page from version 2 to 3 right now and running into this again. This PR merged would be really nice :-)

@afonic
Copy link
Copy Markdown

afonic commented Sep 4, 2020

I agree, this breaks assets for a multi-site setup if I'm not mistaken.

@FlorianMoser
Copy link
Copy Markdown

I'm also stuck with this. Of course, you can create a symlink from /public/{locale}/{cache_path} to /public/{cache_path} as suggested in the docs. But then you cannot access the URL /{locale} anymore, because this is now an existing (but empty) directory.

@andjsch
Copy link
Copy Markdown
Contributor Author

andjsch commented Sep 8, 2020

Closed by #2379

@andjsch andjsch closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-site locale in asset path => file not found

6 participants