Skip to content

Fix JSON-LD entity type comparison to be case-insensitive #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanmcclean merged 6 commits into from
Feb 18, 2026
Merged

Fix JSON-LD entity type comparison to be case-insensitive #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e7a3b4
fix: make json ld entity check lowercase
samalisam-novu Feb 17, 2026
8d50014
feat: add json ld lowercase/uppercase tests
samalisam-novu Feb 17, 2026
f9e7fba
Revert "feat: add json ld lowercase/uppercase tests"
duncanmcclean Feb 18, 2026
2bfd554
Revert "fix: make json ld entity check lowercase"
duncanmcclean Feb 18, 2026
8b1d62e
the entity should always be lowercase
duncanmcclean Feb 18, 2026
7474b54
fix test
duncanmcclean Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cascade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ protected function jsonLd()
$jsonLdOrganizationLogo = $this->data->get('json_ld_organization_logo');
$jsonLdPersonName = (string) $this->data->get('json_ld_person_name');

if ($jsonLdEntity === 'Organization' && $jsonLdOrganizationName) {
if ($jsonLdEntity === 'organization' && $jsonLdOrganizationName) {
if ($jsonLdOrganizationLogo && ! $jsonLdOrganizationLogo instanceof Value) {
$jsonLdOrganizationLogo = Asset::find($jsonLdOrganizationLogo);
}
Expand All @@ -602,7 +602,7 @@ protected function jsonLd()
]), JSON_UNESCAPED_SLASHES));
}

if ($jsonLdEntity === 'Person' && $jsonLdPersonName) {
if ($jsonLdEntity === 'person' && $jsonLdPersonName) {
$snippets->push(json_encode([
'@context' => 'https://schema.org',
'@type' => 'Person',
Expand Down
4 changes: 2 additions & 2 deletions tests/CascadeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ public function it_generates_json_ld_data()
$siteDefaults = SiteDefaults::in('default')->set([
'site_name' => 'Cool Writings',
'description' => 'Bob sled team',
'json_ld_entity' => 'Person',
'json_ld_entity' => 'person',
'json_ld_person_name' => 'Derice Bannock',
]);

Expand All @@ -403,7 +403,7 @@ public function it_generates_json_ld_breadcrumbs()
$siteDefaults = SiteDefaults::in('default')->set([
'site_name' => 'Cool Writings',
'description' => 'Bob sled team',
'json_ld_entity' => 'Person',
'json_ld_entity' => 'person',
'json_ld_person_name' => 'Derice Bannock',
'json_ld_breadcrumbs' => true,
]);
Expand Down