Skip to content

Don't require mocking/faking special case BLOCKHASH instruction for VMTests, part 2#92

Merged
mratsim merged 1 commit intomasterfrom
SyncWithEthereumTestRemovalForMockBalanceAndBlockHash
Aug 2, 2018
Merged

Don't require mocking/faking special case BLOCKHASH instruction for VMTests, part 2#92
mratsim merged 1 commit intomasterfrom
SyncWithEthereumTestRemovalForMockBalanceAndBlockHash

Conversation

@tersec
Copy link
Contributor

@tersec tersec commented Aug 1, 2018

…y removing many which rely on mocking BLOCKHASH/BALANCE just for VM tests
@tersec
Copy link
Contributor Author

tersec commented Aug 2, 2018

I've checked that the vast majority of these show up in an appropriate form in https://github.com/ethereum/tests/tree/develop/GeneralStateTests/stSystemOperationsTest per the Foundation's goals (and none still exist as vmTests upstream):

vmSystemOperations:
vmSystemOperations/ABAcalls[0-3]: GeneralStateTests/stSystemOperationsTest/ABAcalls[0-3]
vmSystemOperations/ABAcallsSuicide[01]: GeneralStateTests/stSystemOperationsTest/ABAcallsSuicide[01]
vmSystemOperations/CallRecursiveBomb[0-3]: vmSystemOperations/GeneralStateTests/stSystemOperationsTest/CallRecursiveBomb[0-3]
vmSystemOperations/CallToNameRegistrator0: vmSystemOperations/GeneralStateTests/stSystemOperationsTest/ CallToNameRegistrator0
vmSystemOperations/CallToNameRegistratorNotMuchMemory[01]: vmSystemOperations/GeneralStateTests/stSystemOperationsTest/CallToNameRegistratorNotMuchMemory[01]
vmSystemOperations/CallToNameRegistratorOutOfGas: GeneralStateTests/stSystemOperationsTest/CallToNameRegistratorOutOfGas
vmSystemOperations/CallToNameRegistratorTooMuchMemory[0-2]: GeneralStateTests/stSystemOperationsTest/CallToNameRegistratorTooMuchMemory[0-2]
vmSystemOperations/CallToPrecompiledContract: no close equivalent found in quick search.
vmSystemOperations/CallToReturn1: GeneralStateTests/stSystemOperationsTest/CallToReturn1
vmSystemOperations/PostToNameRegistrator0: no obvious equivalent found.
vmSystemOperations/PostToReturn1: GeneralStateTests/stSystemOperationsTest/PostToReturn1
vmSystemOperations/callcodeToNameRegistrator0: GeneralStateTests/stSystemOperationsTest/callcodeToNameRegistrator0
vmSystemOperations/callcodeToReturn1: GeneralStateTests/stSystemOperationsTest/callcodeToReturn1
vmSystemOperations/callstatelessToNameRegistrator0 and vmSystemOperations/callstatelessToReturn1: no obvious equivalents found.
vmSystemOperations/createNameRegistrator: GeneralStateTests/stSystemOperationsTest/createNameRegistrator
vmSystemOperations/createNameRegistratorOutOfMemoryBonds[01]: GeneralStateTests/stSystemOperationsTest/createNameRegistratorOutOfMemoryBonds[01]
vmSystemOperations/createNameRegistratorValueTooHigh: GeneralStateTests/stSystemOperationsTest/createNameRegistratorValueTooHigh

vmTests:
arith, boolean, and mktx are broken -- as documented by https://github.com/status-im/nimbus/pull/90

vmRandomTest: exact replacements aren't there, but https://github.com/ethereum/tests/tree/develop/GeneralStateTests/stRandom and https://github.com/ethereum/tests/tree/develop/GeneralStateTests/stRandom2 and well-stocked with moral equivalents. I looked at each of these by hand, and they're not particularly useful except as generic sorts of fuzz-testing (but see above).

@tersec tersec requested review from coffeepots and mratsim August 2, 2018 04:17
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mratsim mratsim merged commit d94dfbd into master Aug 2, 2018
@coffeepots
Copy link
Contributor

LGTM too.

@tersec tersec deleted the SyncWithEthereumTestRemovalForMockBalanceAndBlockHash branch August 14, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments