Skip to content

Conversation

@GeoDaoyu
Copy link
Contributor

Resolves #9357.

Description

What is the purpose of this pull request?

This pull request:

  • fix C lint errors

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

According to
lib/node_modules/@stdlib/stats/base/snanstdevwd/src/snanstdevwd.c

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 25, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 25, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/snanstdevwd $\color{green}365/365$
$\color{green}+0.00%$
$\color{green}14/14$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}365/365$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 25, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. @GeoDaoyu do we also need to update the README or no?

@GeoDaoyu
Copy link
Contributor Author

外观不错。@GeoDaoyu我们是否还需要更新README文件?

which README do you mean?
this? lib/node_modules/@stdlib/stats/base/snanstdevwd/README.md

what should I do?

@kgryte
Copy link
Member

kgryte commented Dec 26, 2025

@GeoDaoyu Correct. My question is whether we need to copy over the changes in the example.c file to the README, provided the README includes the C example.

@GeoDaoyu
Copy link
Contributor Author

I think we don't need to update the README.
Because all the examples in the readme are in js, not in c.

@kgryte
Copy link
Member

kgryte commented Dec 26, 2025

You're right. That package doesn't appear to have been updated yet. Thanks for checking!

@GeoDaoyu
Copy link
Contributor Author

If we should add c examples to README.
Should we add an another RFC? There are too many examples like this.

@kgryte
Copy link
Member

kgryte commented Dec 26, 2025

We do need to add C examples, but we've been doing that as we migrate the strided packages from stats/base to stats/strided. No need to open an RFC at the moment, as that migration is currently blocked.

@kgryte kgryte merged commit 8006652 into stdlib-js:develop Dec 26, 2025
12 checks passed
@GeoDaoyu GeoDaoyu deleted the fix/CLint9357 branch January 7, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants