feat: add configurable path suffix cleanup and heredoc formatting#20
feat: add configurable path suffix cleanup and heredoc formatting#20h4rk8s wants to merge 1 commit intosteipete:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0c8c51d9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Pattern: path followed by optional :line:col and trailing colon | ||
| // Matches: /path/file: or /path/file:42: or /path/file:42:10: | ||
| let pathPattern = #"^([/~][\S]*?)(:\d+)?(:\d+)?:$"# |
There was a problem hiding this comment.
Match path suffixes on paths containing spaces
The new suffix-cleanup regex only allows non-whitespace characters in the path ([\S]*), so inputs like /Users/me/My Project/file.swift:42: never match and the cleanup silently returns nil. In this case the next pipeline step can still quote the path, but it preserves the :42: suffix, so users still get an unusable path when directories contain spaces (a common macOS case).
Useful? React with 👍 / 👎.
Summary
trimPathSuffixandformatHeredocsettings in General preferences/path/file.swift:42:->/path/file.swift)Validation
swift testpasses locallypnpm checkcurrently fails on repository-wide baseline SwiftFormat issues in untouched files