Skip to content

[New Tx Flow] Fix bugs and update 'restore footprint' & 'extend ttl' functinality#2006

Merged
jeesunikim merged 7 commits intofeature/new-tx-flowfrom
new-tx-flow-fix-extend-restore-footprint
Apr 6, 2026
Merged

[New Tx Flow] Fix bugs and update 'restore footprint' & 'extend ttl' functinality#2006
jeesunikim merged 7 commits intofeature/new-tx-flowfrom
new-tx-flow-fix-extend-restore-footprint

Conversation

@jeesunikim
Copy link
Copy Markdown
Contributor

@jeesunikim jeesunikim commented Apr 3, 2026

  • Applied the new store to contract storage to enable link via session storage via url

  • Removed the old prepare transaction for restore footprint/extend footprint related operation

  • authMode to be enabled only for invoke_contract_function

  • Always show submit via RPC if it's a soroban op and rpc is available

  • Fix View in Dashboard link. The previous openUrl didn't work well with messy url

  • restore_footprint build step

restore-footprint-01
  • restore_footprint simulate step
restore-footprint-02
  • successfully restored
restore-footprint-03

jeesunikim and others added 5 commits April 3, 2026 11:37
…time setState

- Add explicit switch cases for destination/source_account in ClassicOperation
  so onChange receives a string (not ChangeEvent) matching the component's API
- Move setBuildClassicXdr into useEffect to avoid setState during render
- Ensure all hooks run before early returns to fix "more hooks" error
- Fix duplicate React key in SignerSelector dropdown items

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e removal, and ContractStorage restore

- Re-run Operations init effect when store resets to empty (clear all fix)
- Pass source_account onChange as plain string (remove fake event wrapper)
- Gate validation error card on hasFormContent to avoid flash after clear
- Use window.open directly for internal dashboard links (bypass sanitizeUrl)
- Remove resource_fee from restore_footprint/extend_footprint_ttl params
- Migrate ContractStorage handleRestore to useBuildFlowStore

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ntent guard

- Remove Resource Fee field interactions from Soroban extend/restore tests
- Update initial state test to reflect hidden errors on blank form
- Update clear-all test to expect errors hidden after reset

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Apr 3, 2026
@stellar-jenkins-ci
Copy link
Copy Markdown

@jeesunikim jeesunikim marked this pull request as ready for review April 3, 2026 23:08
Revert hasFormContent guard so required-field errors are always visible,
helping users see what's needed upfront.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@stellar-jenkins-ci
Copy link
Copy Markdown

@jeesunikim jeesunikim requested a review from quietbits April 4, 2026 06:39
@stellar-jenkins-ci
Copy link
Copy Markdown

@jeesunikim jeesunikim merged commit f8d57f6 into feature/new-tx-flow Apr 6, 2026
4 checks passed
@jeesunikim jeesunikim deleted the new-tx-flow-fix-extend-restore-footprint branch April 6, 2026 18:42
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants