[New TX Flow] Address copilot's suggestions#2014
Merged
jeesunikim merged 5 commits intofeature/new-tx-flowfrom Apr 8, 2026
Merged
[New TX Flow] Address copilot's suggestions#2014jeesunikim merged 5 commits intofeature/new-tx-flowfrom
jeesunikim merged 5 commits intofeature/new-tx-flowfrom
Conversation
jeesunikim
commented
Apr 7, 2026
| /** | ||
| * Determines if the simulation result indicates a read-only transaction | ||
| * (no auth entries and no write footprint). | ||
| * (no write footprint). |
jeesunikim
commented
Apr 7, 2026
|
|
||
| return ( | ||
| <div | ||
| role="button" |
jeesunikim
commented
Apr 7, 2026
| const className = `Tab ${addlClassName ?? ""}`; | ||
|
|
||
| if (t.href) { | ||
| if (t.href && !t.isDisabled) { |
jeesunikim
commented
Apr 7, 2026
| // directly in handleCustomSignAll. | ||
| useEffect(() => { | ||
| if (allSigned) { | ||
| if (allSigned && signMode === "individual") { |
jeesunikim
commented
Apr 7, 2026
|
|
||
| // Clear previous validated result so a failed re-validation can't leave | ||
| // stale validatedXdr enabling the next step. | ||
| setValidatedXdr(undefined); |
jeesunikim
commented
Apr 7, 2026
| // signing + assembly, or after auto-assembly when no auth entries are | ||
| // present) so the sign step receives a transaction with | ||
| // simulation-derived resources/fees. | ||
| return !simulate.simulationResultJson || !simulate.assembledXdr; |
jeesunikim
commented
Apr 7, 2026
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
quietbits
approved these changes
Apr 8, 2026
src/app/(sidebar)/transaction/build/components/SimulateStepContent.tsx
Outdated
Show resolved
Hide resolved
| variant="success" | ||
| variant={variant} | ||
| title="Your transaction envelope XDR is ready." | ||
| icon={<Icon.CheckCircle />} |
Contributor
There was a problem hiding this comment.
If the variant is dynamic, should the icon be dynamic as well?
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left a direct link to the comment in each updated file