Boost.Asio compatibility#2273
Conversation
|
One of the tests failed for ccda9c5. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/copr/3194150 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/10068660/ |
|
One of the tests failed for a6a0e4b. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/copr/3194803 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/10069074/ |
|
One of the tests failed for b6ac8a5. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/copr/3197101 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/10071319/ |
b6ac8a5 to
91376f9
Compare
|
@stephenberry could you please review this? |
|
The PR description mentions:
However, these helpers don't appear in the actual diff. The implementation instead uses:
Could you update the PR description to reflect the actual changes? The current approach works fine, but the description is misleading. |
|
Indeed, that's a leftover from a previous attempt. I'll update. |
|
There, it's done. |
|
@azais-corentin, thanks so much working this fix! It looks great! I'm merging it |
This fixes #2266.
Summary
This PR fixes the
boost-asio.ymlworkflow which was incorrectly using standalone Asio instead of Boost.Asio, and resolves compilation errors when building with Boost.Asio.Changes
CI workflow (
boost-asio.yml):-Dglaze_USE_BUNDLED_ASIO=OFF)Boost_ROOTenvironment variable to properly locate Boost installationBoost.Asio compatibility:
asio::error_codeisboost::system::error_codewhich is not implicitly convertible tostd::error_code.Changed async callback signatures to use
asio::error_codeconsistently.Use make_error_code(asio::error::eof) and make_error_code(asio::error::operation_aborted) for comparisons.
<asio/ssl.hpp>or<boost/asio/ssl.hpp>) toglaze_asio.hppglaze_asio.hppinstead of<asio.hpp>directly for proper abstraction