Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
mimic = std::stringnot working instd::vector<std::pair<...>>(Issue #2285)Problem
When a custom type with
mimic = std::stringwas used as a key instd::vector<std::pair<...>>, JSON writing worked correctly but reading failed with anexpected_quoteerror.Cause
The JSON read code was missing
mimics_str_tchecks in two locations where pair keys are parsed, while the write code correctly handled this case.Fix
Added
mimics_str_tto the key type checks ininclude/glaze/json/read.hpp:from<JSON, pair_t<T>>specializationfrom<JSON, readable_array_t<T>>specialization for vector-of-pairs