[maple_upload] Improve script on linux and macosx#62
Merged
fpistm merged 5 commits intostm32duino:masterfrom May 5, 2020
GrantM11235:maple-script
Merged
[maple_upload] Improve script on linux and macosx#62fpistm merged 5 commits intostm32duino:masterfrom GrantM11235:maple-script
fpistm merged 5 commits intostm32duino:masterfrom
GrantM11235:maple-script
Conversation
This makes it possible to recover if upload-reset isn't working, for example if a board is running a sketch without USB CDC enabled Changes: * Uncomment `set -e` * Ask the user to manually reset their device if upload-reset fails * Retry dfu-util if no device is found * Print periods while waiting for serial port * Exit with an error if script times out while waiting for serial port * Send all messages to STDERR
fpistm
requested changes
May 4, 2020
Member
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
Thanks for this PR.
shfmt was used to check format, see my comments.
And one thought about the number of retry.
Contributor
Author
|
Thanks for the review! Let me know if I should squash those fixes in to the first commit or if I should squash everything to one commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to recover if upload-reset isn't working, for example if a board is running a sketch without USB CDC enabled
Changes:
set -e