Skip to content

Updated marked to version 0.3.9#53

Merged
Hypnosphi merged 2 commits into
storybookjs:masterfrom
jbovenschen:fix-security-vulnerabilities
Jan 4, 2018
Merged

Updated marked to version 0.3.9#53
Hypnosphi merged 2 commits into
storybookjs:masterfrom
jbovenschen:fix-security-vulnerabilities

Conversation

@jbovenschen
Copy link
Copy Markdown
Member

Which has patches for security vulnerabilities CVE-2017-17461 and CVE-2017-1000427.

@ndelangen
Copy link
Copy Markdown
Member

test if failing over:

Package size limit has exceeded by 33 B
  Package size: 30.03 KB
  Size limit:   30 KB
  With all dependencies, minified and gzipped

😒

@jbovenschen
Copy link
Copy Markdown
Member Author

jbovenschen commented Jan 4, 2018

This PR fails due to the increased size of marked (Due to the security patches). Shouldn't be a problem for now I guess? Personally I think it is better to investigate how to decrease it again after we published it.

@ndelangen I would update it within the package.json to 31kb for know ok?

It sucks a little because it is only 0.19kb extra.

@Hypnosphi
Copy link
Copy Markdown
Member

Let's raise the limit, of course

@Hypnosphi Hypnosphi merged commit 277a8ad into storybookjs:master Jan 4, 2018
@jbovenschen jbovenschen deleted the fix-security-vulnerabilities branch January 4, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants