Skip to content

Build: Update @types/node#34037

Merged
valentinpalkovic merged 1 commit intonextfrom
valentin/update-node-types
Mar 6, 2026
Merged

Build: Update @types/node#34037
valentinpalkovic merged 1 commit intonextfrom
valentin/update-node-types

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 6, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated Node.js TypeScript type definitions to the latest compatible version, ensuring consistency with the development environment and type-checking tools.

@valentinpalkovic valentinpalkovic self-assigned this Mar 6, 2026
@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:normal labels Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 427e7d8

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 6, 2026

View your CI Pipeline Execution ↗ for commit 427e7d8

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 14m 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 07:50:48 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82823170-3dc0-447c-93a9-b913b19b38a0

📥 Commits

Reviewing files that changed from the base of the PR and between bb7e528 and 427e7d8.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Updated the @types/node dependency resolution in package.json from version ^22.0.0 to ^22.19.1. This is a patch version bump within the same minor version constraint.

Changes

Cohort / File(s) Summary
Dependency Version Update
package.json
Updated @types/node resolution from ^22.0.0 to ^22.19.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 427e7d8, ran on 6 March 2026 at 07:46:28 UTC

The following packages have significant changes to their size or dependencies:

@storybook/builder-webpack5

Before After Difference
Dependency count 185 185 0
Self size 76 KB 76 KB 0 B
Dependency size 32.19 MB 32.17 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 185 185 0
Self size 139 KB 139 KB 🚨 +48 B 🚨
Dependency size 30.40 MB 30.38 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 189 189 0
Self size 15 KB 15 KB 🚨 +18 B 🚨
Dependency size 28.90 MB 28.88 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 534 534 0
Self size 648 KB 648 KB 0 B
Dependency size 59.86 MB 59.84 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 92 92 0
Self size 1.12 MB 1.12 MB 🚨 +36 B 🚨
Dependency size 22.47 MB 22.45 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 124 124 0
Self size 30 KB 30 KB 🎉 -18 B 🎉
Dependency size 23.76 MB 23.74 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 82 82 0
Self size 35 KB 35 KB 0 B
Dependency size 20.25 MB 20.24 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 271 271 0
Self size 24 KB 24 KB 🚨 +12 B 🚨
Dependency size 44.53 MB 44.51 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 197 197 0
Self size 16 KB 16 KB 0 B
Dependency size 33.44 MB 33.42 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 779 KB 779 KB 🎉 -84 B 🎉
Dependency size 67.35 MB 67.33 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 32 KB 32 KB 🎉 -36 B 🎉
Dependency size 65.87 MB 65.86 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/preset-react-webpack

Before After Difference
Dependency count 167 167 0
Self size 18 KB 18 KB 🎉 -24 B 🎉
Dependency size 31.40 MB 31.38 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 58 58 0
Self size 1.19 MB 1.19 MB 🚨 +6 B 🚨
Dependency size 13.21 MB 13.19 MB 🎉 -19 KB 🎉
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic moved this to In Progress in Core Team Projects Mar 6, 2026
@valentinpalkovic valentinpalkovic merged commit 40d4e8b into next Mar 6, 2026
122 of 133 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/update-node-types branch March 6, 2026 13:15
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core Team Projects Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant