UI: Use correct selector for addon panel focus check#34164
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 8e90c6e
☁️ Nx Cloud last updated this comment at |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughIntroduces an internal helper Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches
📝 Coding Plan
Comment |
5d75f46 to
c22afbb
Compare
yannbf
approved these changes
Mar 17, 2026
8 tasks
Merged
1 task
This was referenced Mar 18, 2026
Merged
1 task
This was referenced Mar 18, 2026
This was referenced Mar 18, 2026
1 task
This was referenced Apr 15, 2026
1 task
This was referenced Apr 17, 2026
Open
1 task
This was referenced Apr 26, 2026
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10.3 QA - Keyboard focus lost when closing the addon panel via shortcuts
If you end up opening the addon panel through keyboard shortcuts, then close it via shortcuts, the keyboard focus is lost.
This is because the focus containment check targeted an element within the addon panel region instead of the whole region, which receives focus when opening the panel with the button.
Summary by CodeRabbit
Refactor
Chores