Fix tests in node 11 by using Array#sort correctly#4720
Merged
Conversation
Hypnosphi
added
bug
addon: info
patch:yes
Hypnosphi
requested review from
dangreenisrael,
danielduan,
theinterned,
usulpro and
z4o4z
as code owners
igor-dv
approved these changes
Nov 5, 2018
Member
Author
|
See also nodejs/node#22754 (comment) |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Nov 6, 2018
Fix tests in node 11 by using `Array#sort` correctly
This was referenced Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting algorithm has changed in latest V8, and it doesn't work with our improper usage (returning boolean instead of number) anymore
How to test