Skip to content

Use current Ed25519 OID #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
str4d merged 1 commit into from
Dec 4, 2016
Merged

Use current Ed25519 OID #20

str4d merged 1 commit into from
Dec 4, 2016

Conversation

@jimktrains
Copy link
Contributor

@jimktrains jimktrains commented Nov 30, 2016

@str4d
Copy link
Owner

str4d commented Dec 4, 2016

Thanks for this!

@str4d str4d merged commit a8313b2 into str4d:master Dec 4, 2016
@str4d
Copy link
Owner

str4d commented Dec 5, 2016

@jimktrains For historical note: your PR only changed the OID for encoding, not for decoding (but that's my fault for not spotting it before merging). It also turns out that the new draft is not just an OID change, but a significant formatting change; hence I should not have merged this PR before requiring further changes. However, I'm going to leave it merged so that it forces me to get this fixed 😅

@str4d
Copy link
Owner

str4d commented Dec 5, 2016

Actually, on second thought I've reverted this commit (and the commit I made to change the OID for decoding), in favour of preserving the existing functions, to provide a migration path for library users.

@str4d
Copy link
Owner

str4d commented Dec 5, 2016

I've opened #21 to track ongoing progress.

@str4d str4d modified the milestone: 0.2 Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jimktrains @str4d