Make wcwidth Python library into a soft dependency in the source code#282
Merged
Conversation
Member
Author
|
With wcwidth installed. There's a bit of misalignment here, due to some Firefox or markup behavior, but it's not there on my terminal. Without wcwidth installed. Here there is lots of misalignment. |
mulkieran
changed the title
mulkieran
changed the title
It may not be properly installed on some distributions. Signed-off-by: mulhern <amulhern@redhat.com>
Also, add a note about how defaulting to len changes the behavior. Signed-off-by: mulhern <amulhern@redhat.com>
In most of the code, "width" means number of cells, "length" means number of chars. It's easier to read if the naming is consistent here as well. Signed-off-by: mulhern <amulhern@redhat.com>
Member
Author
|
rebased. |
drckeefe
approved these changes
May 30, 2019
bgurney-rh
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to more incorrect alignment of columns containing non-standard width characters if wcwidth Python library is unavailable.
It would be wrong for the whole program to fail to run because it might not align its output properly in columns if it did run.
Make some additional changes congruent with this change.
Do not change the dependency requirement for wcwidth in setup.py.
setup.pyis what pip relies on, and wcwidth is available on PyPi, so that is the correct thing to do.