Skip to content

Only create placeholder device when encryption is enabled#3856

Closed
jbaublitz wants to merge 1 commit intostratis-storage:masterfrom
jbaublitz:issue-stratisd-3840
Closed

Only create placeholder device when encryption is enabled#3856
jbaublitz wants to merge 1 commit intostratis-storage:masterfrom
jbaublitz:issue-stratisd-3840

Conversation

@jbaublitz
Copy link
Copy Markdown
Member

Closes #3840

@jbaublitz jbaublitz self-assigned this Jun 9, 2025
@jbaublitz jbaublitz moved this to In Progress in 2025June Jun 9, 2025
@jbaublitz jbaublitz marked this pull request as draft June 9, 2025 18:06
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3856
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link
Copy Markdown

Cockpit tests failed for commit a5b83bc. @martinpitt, @jelly, @mvollmer please check.

@jbaublitz jbaublitz force-pushed the issue-stratisd-3840 branch 2 times, most recently from e531f88 to 420832e Compare June 17, 2025 01:07
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3856
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

2 similar comments
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3856
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3856
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jbaublitz jbaublitz force-pushed the issue-stratisd-3840 branch 2 times, most recently from 2e908c2 to 19695b2 Compare June 17, 2025 15:55
@jbaublitz jbaublitz marked this pull request as ready for review June 17, 2025 17:33
@jbaublitz jbaublitz moved this from In Progress to In Review in 2025June Jun 17, 2025
@jbaublitz
Copy link
Copy Markdown
Member Author

@mulkieran Okay, I believe this is ready for review. The only tests that seem to be failing are the rawhide tests.

@jbaublitz jbaublitz requested a review from mulkieran June 17, 2025 17:34
@jbaublitz
Copy link
Copy Markdown
Member Author

After we just discussed this, this will likely be demoted to 3.9.0 or 3.9.1 depending on how hard it is to evaluate the need for migration code.

@jbaublitz jbaublitz force-pushed the issue-stratisd-3840 branch from 19695b2 to cb9567f Compare June 17, 2025 19:21
@jbaublitz
Copy link
Copy Markdown
Member Author

Blocked by #3800

@jbaublitz jbaublitz force-pushed the issue-stratisd-3840 branch from cb9567f to 96b24f6 Compare June 18, 2025 04:03
@jbaublitz jbaublitz added this to the v3.9.1 milestone Jun 20, 2025
@jbaublitz jbaublitz force-pushed the issue-stratisd-3840 branch 4 times, most recently from 2e94cf6 to a3a2687 Compare June 30, 2025 15:01
@mulkieran mulkieran removed this from 2025June Jul 8, 2025
@mulkieran mulkieran moved this to In Review in 2025July Jul 8, 2025
@mulkieran mulkieran removed this from 2025July Aug 8, 2025
@mulkieran mulkieran moved this to In Review in 2025August Aug 8, 2025
@mulkieran mulkieran removed this from 2025August Sep 2, 2025
@mulkieran mulkieran moved this to In Review in 2025September Sep 2, 2025
@mulkieran mulkieran moved this to In Review in 2025October Oct 11, 2025
@mulkieran mulkieran removed this from 2025October Nov 17, 2025
@mulkieran mulkieran moved this to Pending in 2025November Nov 17, 2025
@mulkieran mulkieran removed this from 2025November Dec 1, 2025
@mulkieran mulkieran moved this to Pending in 2025December Dec 1, 2025
@mulkieran mulkieran removed this from 2025December Jan 2, 2026
@mulkieran mulkieran moved this to Pending in 2026January Jan 2, 2026
@mulkieran mulkieran removed this from 2026January Feb 17, 2026
@mulkieran mulkieran moved this to Pending in 2026February Feb 17, 2026
@mulkieran mulkieran removed this from 2026February Mar 2, 2026
@mulkieran mulkieran moved this to Pending in 2026March Mar 2, 2026
@jbaublitz
Copy link
Copy Markdown
Member Author

@mulkieran I believe this may be rendered obsolete by the performance testing. I think the only thing we may need to test is slower drives. If there's a large performance degradation in V2, this may be worth pursuing.

@jbaublitz jbaublitz closed this Apr 7, 2026
@github-project-automation github-project-automation Bot moved this from Pending to Done in 2026March Apr 7, 2026
@mulkieran mulkieran removed this from 2026March Apr 7, 2026
@mulkieran mulkieran removed this from the v3.9.1 milestone Apr 7, 2026
@jbaublitz
Copy link
Copy Markdown
Member Author

I confirmed with @spetrovi that performance is consistent across slower and faster drives. I'm going to close the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only create cache device placeholder when encryption is enabled

2 participants