Skip to content

Increase libcryptsetup-rs dependency lower bound to 0.14.0#3903

Merged
mulkieran merged 2 commits intostratis-storage:masterfrom
mulkieran:libcryptsetup-rs-0.14.0
Aug 27, 2025
Merged

Increase libcryptsetup-rs dependency lower bound to 0.14.0#3903
mulkieran merged 2 commits intostratis-storage:masterfrom
mulkieran:libcryptsetup-rs-0.14.0

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Aug 27, 2025

Related stratis-storage/project#811

Summary by CodeRabbit

  • Chores
    • CI configuration updated to include an additional repository for COPR builds across pull-request and commit workflows, covering all configured targets.
    • Dependency alignment: upgraded the underlying cryptsetup library to version 0.14.0.
    • No changes to application behavior or interfaces expected.
    • Build and release processes remain unchanged for end users.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Aug 27, 2025
@mulkieran mulkieran moved this to In Review in 2025August Aug 27, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 27, 2025

Walkthrough

Adds a COPR additional_repos entry to two Packit jobs in .packit.yaml and bumps the libcryptsetup-rs dependency version in Cargo.toml from 0.13.1 to 0.14.0. No code logic or public API changes.

Changes

Cohort / File(s) Summary of Changes
COPR build config
./.packit.yaml
Added additional_repos for copr_pull and copr_commit jobs: copr://packit/stratis-storage-libcryptsetup-rs-master.
Dependency version bump
./Cargo.toml
Updated [dependencies.libcryptsetup-rs] version from 0.13.1 to 0.14.0; features and options unchanged.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Poem

A rabbit taps the Cargo lock, hop-hop, so neat,
Nudges cryptsetup’s number up a tidy seat.
In COPR fields, new repos sprout,
The build winds hum, without a doubt.
Ears up, paws down—release complete! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a75b640 and 83b36e1.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .packit.yaml (1 hunks)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: testing-farm:fedora-rawhide-x86_64:cockpit
  • GitHub Check: testing-farm:fedora-43-x86_64:cockpit
  • GitHub Check: testing-farm:fedora-rawhide-x86_64:local
  • GitHub Check: testing-farm:fedora-43-x86_64:local
  • GitHub Check: testing-farm:fedora-41-x86_64:local
  • GitHub Check: testing-farm:fedora-42-x86_64:local
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: checks (make -f Makefile test, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile build, 1.89.0, cargo)
  • GitHub Check: checks (PROFILEDIR=debug make -f Makefile build, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile build-min, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile build-no-ipc, 1.89.0, cargo)
  • GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-min-no-systemd, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile test, 1.89.0, cargo)
  • GitHub Check: checks (PROFILEDIR=debug make -f Makefile build, 1.89.0, cargo)
  • GitHub Check: checks_with_tang_should_fail (TANG_URL=localhost make -f Makefile test-clevis-loop-should-fail-ro...
  • GitHub Check: stratis-min-cli-checks
  • GitHub Check: stratis-cli-checks
  • GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-utils, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile build-no-ipc, 1.89.0, cargo)
  • GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-min-no-systemd, 1.89.0, cargo)
  • GitHub Check: checks (make -f Makefile build, 1.89.0, cargo)
  • GitHub Check: python-based-tests
  • GitHub Check: tests-with-testing-repo (master)
  • GitHub Check: checks_with_udev (RUST_LOG=stratisd=debug make -f Makefile test-loop-root, 1.89.0, cargo)
  • GitHub Check: checks_with_udev (RUST_LOG=stratisd=debug make -f Makefile test-loop-root, 1.89.0, cargo)
🔇 Additional comments (2)
Cargo.toml (1)

144-147: Please verify libcryptsetup-rs 0.14.0 and the “mutex” feature

I’ve confirmed the version bump in your manifest and lockfile, but the applied features aren’t explicitly shown in the lockfile. To be certain everything lines up:

• Cargo.lock shows:
name = "libcryptsetup-rs"
version = "0.14.0"
• Cargo.toml (lines 144–147) has:
version = "0.14.0"
features = ["mutex"]
optional = true

However, since the lockfile didn’t list features = ["mutex"], please run locally:

cargo metadata --format-version 1 --no-deps | jq '.packages[] 
  | select(.name=="libcryptsetup-rs") 
  | .features'
cargo +1.77.0 check

to confirm the “mutex” feature is enabled and that the crate still builds under Rust 1.77.0 with libcryptsetup-rs-sys 0.6.0.

.packit.yaml (1)

36-38: additional_repos correctly configured for both COPR jobs
I’ve confirmed that both the copr_pull and copr_commit jobs in .packit.yaml include the additional_repos entry with the copr://packit/stratis-storage-libcryptsetup-rs-master shorthand, which is supported by Packit and recognized by COPR during builds. No changes are necessary.

• Optional: if your builds cannot reach the external COPR repo during the build phase, you can enable network access by adding enable_net: true to these jobs.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mulkieran mulkieran marked this pull request as ready for review August 27, 2025 17:42
@mulkieran
Copy link
Member Author

This should pass all tests...

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3903-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran changed the title Libcryptsetup rs 0.14.0 Increase libcryptsetup-rs dependency lower bound to 0.14.0 Aug 27, 2025
@mulkieran mulkieran requested a review from jbaublitz August 27, 2025 18:04
@mulkieran
Copy link
Member Author

AVC's again in Cockpit...

@mulkieran
Copy link
Member Author

Builds succeeded, merging...

@mulkieran mulkieran removed the request for review from jbaublitz August 27, 2025 18:51
@mulkieran mulkieran merged commit 6ed45e5 into stratis-storage:master Aug 27, 2025
50 of 52 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025August Aug 27, 2025
@mulkieran mulkieran deleted the libcryptsetup-rs-0.14.0 branch August 27, 2025 18:51
@mulkieran mulkieran added this to the v3.9.0 milestone Aug 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant