Closed
Conversation
This reverts commit 814075f. objx v0.5.2 unnecessarly upgrades the minimum Go version from 1.13 to 1.20.
Collaborator
|
v1.17 builds all passed, what is the actual minimum version this imposed on users? |
brackendawson
requested changes
Mar 4, 2024
Collaborator
brackendawson
left a comment
brackendawson
left a comment
There was a problem hiding this comment.
I believe this is not necessary.
Because a go directive before 1.21 is advisory and objx set it to 1.20 (for no reason), it is not possible for the configuration in v1.9.0 to generate an error. Testify's advisory 1.17 takes precedence, for what that is worth.
If objx set it to 1.22, then 1.21 toolchains would refuse to import testify v1.9.0 and our oldstable and 1.21 builds would have failed. This would be a good reason to keep every version between 1.17 and stable in our tests.
Collaborator
Author
|
#1567 replaces this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objx
v0.5.2unnecessarly upgrades the minimum Go version from 1.13 to 1.20.v0.5.1is just enough.Changes
Motivation
objx
v0.5.1is just enough. But stretchr/objx#149 changed the minimum Go version from 1.13 to 1.20.We don't want to force users to upgrade Go to use the latest testify version while we don't use specific features of those later versions.
Related issues
Revert #1552.
See stretchr/objx#149.