[breaking] Update CheckoutProvider to use new shape#615
Merged
pololi-stripe merged 5 commits intomasterfrom Sep 12, 2025
Merged
[breaking] Update CheckoutProvider to use new shape#615pololi-stripe merged 5 commits intomasterfrom
pololi-stripe merged 5 commits intomasterfrom
Conversation
pololi-stripe
commented
Sep 5, 2025
| elementsOptions: PropTypes.object, | ||
| }).isRequired, | ||
| }; | ||
| } as PropTypes.ValidationMap<CheckoutProviderProps>; |
Contributor
Author
There was a problem hiding this comment.
I have to as here because propTypes doesn't support PropTypes.instanceOf(Promise<string>)
pololi-stripe
force-pushed
the
pololi/add-clover-custom-checkout-sdk
branch
3 times, most recently
from
c6de04a to
86eb1c3
Compare
pololi-stripe
force-pushed
the
pololi/add-clover-custom-checkout-sdk
branch
from
86eb1c3 to
dc3fe7a
Compare
pololi-stripe
force-pushed
the
pololi/add-clover-custom-checkout-sdk
branch
from
dc3fe7a to
67ba2ed
Compare
This reverts commit 67ba2ed.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & motivation
This is to change
<CheckoutProvider />to use https://js.stripe.com/clover/stripe.jsfetchClientSecret: () => Promise<string>;toclientSecret: string | Promise<string>useCheckoutreturn the exact same object as https://github.com/stripe/react-stripe-js/releases/tag/v4.0.0API review
Copy this template or link to an API review issue.
Testing & documentation