Fix for react-scripts 2.0.2, 2.0.3, 2.0.4#28
Merged
Conversation
|
Quite the cleanup 👍 |
Owner
|
Hello, thank you for the pull request. It will be until tonight (EST) at the earliest before I can test this and get it out the door. |
Contributor
Author
|
No rush from my side :) I'm also closely watching this PR, which would enable TS in CRA 2: react/create-react-app#4837 (comment). Seems close to release |
strothj
changed the title
strothj
changed the title
Owner
|
Merged in as v3. Thanks again. I'm also watching the progress on that CRA 2 pull request. Will be nice to mark this package depreciated :-P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #24; since react-scripts 2.0.2 this doesn't work anymore.
The difference:
2.0.0: https://github.com/facebook/create-react-app/blob/react-scripts%402.0.0/packages/react-scripts/config/webpack.config.dev.js
2.0.2 https://github.com/facebook/create-react-app/blob/react-scripts%402.0.2/packages/react-scripts/config/webpack.config.dev.js
The main difference is that from 2.0.2 and up they've stop using
useand instead went withloader, this should probably have something to do with a webpack upgrade?I've also removed the svg loader fix, since this should be working if you're using the newest version of react-scripts(tested😅)