[CSS] Add nested rules support #3785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves sublimehq#3688 This commit implements support for nested selectors and rule lists according to current draft specification at https://drafts.csswg.org/css-nesting-1.
This commit removes obsolete includes from `property-list-body` context. - `property-values` is no longer matched as `:` pushes `nested-selectors` - `illegal-blocks` is replaced by nested `property-lists`
Collaborator
Author
|
While changes to CSS are simple, the impact on all sorts of inherited syntaxes used in ASP, JSP, Rails, PHP, ... is rather significant. Sometimes it's enough to change syntax test assertion punctuations. But there are also cases, which need more work. |
By excluding `prototype` from rule-lists this commit ensures, template tags are correctly scoped as part of a selector, property-name or property-value. That's important as `:` no longer denotes beginning of property-values, but is the beginning of nested selectors. Some extra `;` are added in syntax tests to make sure the following content is scoped correctly. That's required as assertion comments are sometimes scoped as selectors, caused by comment styles not being supported within CSS.
deathaxe
added a commit
to SublimeText/Less
that referenced
this pull request
Jun 27, 2023
This commit makes sure to give Less's `&` precedence. Less and CSS4 treat `&` different. see: sublimehq/Packages#3785
deathaxe
added a commit
to SublimeText/Liquid
that referenced
this pull request
Jun 27, 2023
This commit makes sure to correctly apply propety-name meta scope, even if property name starts with interpolation. Prepares for sublimehq/Packages#3785 Requires ST4149+
Collaborator
Author
|
Tailwind CSS has implemented this PRs changeset for a while without negative feedback. Less and Liquid have been updated accordingly. Other packages like Vue, Blade seem uneffected. Chrome and Safari support CSS nesting, Firefox has announced support. |
keith-hall
approved these changes
Jun 27, 2023
jfcherng
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3688
This commit implements support for nested selectors and rule lists according to current draft specification at https://drafts.csswg.org/css-nesting-1.