Skip to content

Improved Catnip#8

Merged
philmtd merged 6 commits into
subshell:masterfrom
philmtd:new-catnip
Feb 14, 2023
Merged

Improved Catnip#8
philmtd merged 6 commits into
subshell:masterfrom
philmtd:new-catnip

Conversation

@philmtd
Copy link
Copy Markdown
Member

@philmtd philmtd commented Feb 3, 2023

This is a larger change that was required in order to improve the overall user experience of O-Neko catnip.

The main changes are:

  • After opening a deployment's URL, the user is now redirected to a catnip base-URL which then hosts the frontend
  • Improved frontend-build. Only minimal frameworks in a basic project using Vite, Alpine and Tailwind. This comes with a redesign of the catnip frontend.
  • Now the backend does the polling of the starting deployment while the frontend asks the Catnip backend through a simple API.

This addresses the following issues:

  • users could not reload the wakeup-frontend because then they'd not land on the catnip backend (because the ingress of the starting deployment would exist already)
  • deploys were initiated before serving the frontend. this led to users sometimes not being able to load all frontend resources (css, js), because those requests would already reach the ingress of the starting deployment (and would result in errors)
  • The previously overall mediocre user experience should now be improved

This is a breaking change and it requires the O-Neko changes introduced in subshell/o-neko#102 (and the other way round). Earlier versions of O-Neko will not work with the new catnip and newer versions of O-Neko will not work with earlier catnip versions.

@philmtd
Copy link
Copy Markdown
Member Author

philmtd commented Feb 3, 2023

After this is closed and released, subshell/helm-charts#9 can be merged.

Comment thread frontend/error.html Outdated
Comment thread pkg/deployment/deployment_monitor.go Outdated
Comment thread pkg/deployment/types.go Outdated
Comment thread frontend/src/status-check.ts Outdated
- add logic to wakeup frontend to show whether errors occurred or when deployments are ready
- remove unnecessary oneko api calls
@philmtd philmtd requested a review from schwerlaut February 9, 2023 18:41
@philmtd philmtd merged commit 7bbe046 into subshell:master Feb 14, 2023
@philmtd philmtd deleted the new-catnip branch February 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants