fix: change blocking deploy API calls#102
Merged
Merged
Conversation
philmtd
added
bug
schwerlaut
requested changes
Jan 19, 2023
Co-authored-by: Konrad Schergaut <schergaut@gmail.com>
schwerlaut
reviewed
Feb 7, 2023
Collaborator
schwerlaut
left a comment
schwerlaut
left a comment
There was a problem hiding this comment.
These changes look good to me.
I have a couple of thoughts on one of the controllers for you to consider prior to merging.
Co-authored-by: Konrad Schergaut <schergaut@gmail.com>
schwerlaut
requested changes
Feb 13, 2023
| } | ||
|
|
||
| private <T> void handleImmediateAsyncExceptionWithoutBlocking(CompletableFuture<T> future) { | ||
| if (future.isCompletedExceptionally()) { |
Collaborator
There was a problem hiding this comment.
If triggering the deployment fails already during initialization we might as well throw an exception synchronously.
This way we might get rid of this error-handling here, which to me look's out of place.
Signed-off-by: Philip Dakowitz <dakowitz@subshell.com>
schwerlaut
approved these changes
Feb 14, 2023
| .ifPresent(versionFromDto -> version.setTemplateVariables(versionFromDto.getTemplateVariables()))); | ||
| project.getVersionById(versionId) | ||
| .ifPresent(version -> dto.getVersions() | ||
| .stream() |
Collaborator
There was a problem hiding this comment.
Looks like all this indention change modified the overall readability from "not a lot" to "still not a lot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute deployments asynchronally to stop long blocking calls at the API level