feat: only use urns for referencing simple extensions (#971)

BREAKING CHANGE: drops uri fields from protobufs

Author: benbellick

proto/substrait/extended_expression.proto

@@ -25,14 +25,12 @@ message ExpressionReference {
 // Describe a set of operations to complete.
 // For compactness sake, identifiers are normalized at the plan level.
 message ExtendedExpression {
+  reserved 1;
+
   // Substrait version of the expression. Optional up to 0.17.0, required for later
   // versions.
   Version version = 7;
 
-  // a list of yaml specifications this expression may depend on
-  // this is now deprecated and extension_urns should be used instead.
-  repeated substrait.extensions.SimpleExtensionURI extension_uris = 1 [deprecated = true];
-
   // a list of extension specifications this expression may depend on,
   // referenced by Extension URN
   repeated substrait.extensions.SimpleExtensionURN extension_urns = 8;

proto/substrait/extensions/extensions.proto

@@ -10,19 +10,6 @@ option go_package = "github.com/substrait-io/substrait-protobuf/go/substraitpb/e
 option java_multiple_files = true;
 option java_package = "io.substrait.proto";
 
-// This message is deprecated, use SimpleExtensionURN moving forwards
-message SimpleExtensionURI {
-  option deprecated = true;
-  // A surrogate key used in the context of a single plan used to reference the
-  // URI associated with an extension.
-  // 0 is a valid anchor/reference, but prefer non-zero values for ergonomics.
-  uint32 extension_uri_anchor = 1;
-
-  // The URI where this extension YAML can be retrieved. This is the "namespace"
-  // of this extension.
-  string uri = 2;
-}
-
 message SimpleExtensionURN {
   // A surrogate key used in the context of a single plan used to reference the
   // URN associated with an extension.
@@ -34,7 +21,7 @@ message SimpleExtensionURN {
   string urn = 2;
 }
 
-// Describes a mapping between a specific extension entity and the uri/urn where
+// Describes a mapping between a specific extension entity and the URN where
 // that extension can be found.
 message SimpleExtensionDeclaration {
   oneof mapping_type {
@@ -45,13 +32,9 @@ message SimpleExtensionDeclaration {
 
   // Describes a Type
   message ExtensionType {
-    // references the extension_uri_anchor defined for a specific extension URI.
-    // this is now deprecated and extension_urn_reference should be used instead.
-    uint32 extension_uri_reference = 1 [deprecated = true];
+    reserved 1;
 
     // references the extension_urn_anchor defined for a specific extension URN.
-    // If both extension_urn_reference and extension_uri_reference are present,
-    // extension_urn_reference takes precedence.
     uint32 extension_urn_reference = 4;
 
     // A surrogate key used in the context of a single plan to reference a
@@ -64,13 +47,9 @@ message SimpleExtensionDeclaration {
   }
 
   message ExtensionTypeVariation {
-    // references the extension_uri_anchor defined for a specific extension URI.
-    // this is now deprecated and extension_urn_reference should be used instead.
-    uint32 extension_uri_reference = 1 [deprecated = true];
+    reserved 1;
 
     // references the extension_urn_anchor defined for a specific extension URN.
-    // If both extension_urn_reference and extension_uri_reference are present,
-    // extension_urn_reference takes precedence.
     uint32 extension_urn_reference = 4;
 
     // A surrogate key used in the context of a single plan to reference a
@@ -83,13 +62,9 @@ message SimpleExtensionDeclaration {
   }
 
   message ExtensionFunction {
-    // references the extension_uri_anchor defined for a specific extension URI.
-    // this is now deprecated and extension_urn_reference should be used instead.
-    uint32 extension_uri_reference = 1 [deprecated = true];
+    reserved 1;
 
     // references the extension_urn_anchor defined for a specific extension URN.
-    // If both extension_urn_reference and extension_uri_reference are present,
-    // extension_urn_reference takes precedence.
     uint32 extension_urn_reference = 4;
 
     // A surrogate key used in the context of a single plan to reference a

proto/substrait/plan.proto

@@ -25,14 +25,12 @@ message PlanRel {
 // Describe a set of operations to complete.
 // For compactness sake, identifiers are normalized at the plan level.
 message Plan {
+  reserved 1;
+
   // Substrait version of the plan. Optional up to 0.17.0, required for later
   // versions.
   Version version = 6;
 
-  // a list of yaml specifications this plan may depend on
-  // this is now deprecated and extension_urns should be used instead.
-  repeated substrait.extensions.SimpleExtensionURI extension_uris = 1 [deprecated = true];
-
   // a list of extension URNs this plan may depend on
   repeated substrait.extensions.SimpleExtensionURN extension_urns = 8;
 

text/simple_extensions_schema.yaml

@@ -11,7 +11,7 @@ properties:
     # For reusing type classes and type variations from other extension files.
     # The keys are namespace identifiers that you can then use as dot-separated
     # prefix for type class and type variation names in functions and the base
-    # type class for variations. The values must be extension URIs, following
+    # type class for variations. The values must be extension URNs, following
     # the same format and conventions as those used in the proto plans.
     type: object
     patternProperties: