Skip to content

feat!: remove deprecated usage of URIs for referencing simple extensions#971

Merged
vbarua merged 4 commits intomainfrom
benbellick/drop-uri
Mar 6, 2026
Merged

feat!: remove deprecated usage of URIs for referencing simple extensions#971
vbarua merged 4 commits intomainfrom
benbellick/drop-uri

Conversation

@benbellick
Copy link
Copy Markdown
Member

@benbellick benbellick commented Feb 20, 2026

Closes #970

BREAKING CHANGE: dropping URI usage from protobufs in favor of URNs

@benbellick benbellick changed the title feat!: remove deprecated SimpleExtensionURI and extension_uri_reference feat!: remove deprecated usage of URIs for referencing simple extensions Feb 20, 2026
@benbellick
Copy link
Copy Markdown
Member Author

Please see the issue for some discussion on the change. In summary, it has been 5 months and the most commonly used libraries all support urns, so I think it is time to complete the migration :)

Copy link
Copy Markdown
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should start also removing even less recent deprecations

@yongchul yongchul added awaiting PMC approval PMC Ready PRs ready for review by PMCs labels Mar 3, 2026
Copy link
Copy Markdown
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe to remove now. The only thing I would advocate for is commenting out any of the ... [deprecated = true]; lines to make sure we avoid re-using field numbers, but I also don't feel strongly about it.

@benbellick
Copy link
Copy Markdown
Member Author

@benbellick
Copy link
Copy Markdown
Member Author

I have updated those fields to be reserved.

One other thing to call out. The test files still use URIs to reference other extensions. Though I think it is reasonable to tackle that in a subsequent PR.

@vbarua
Copy link
Copy Markdown
Member

vbarua commented Mar 5, 2026

Sweet, using reserved is perfect for this. That said, let's hold off on merging this. We have some other changes in flight this week, and I think this changes should be in its own release.

On Friday, I will manually trigger a release to flush pending changes out. Then I will merge this change and release it by itself.

@vbarua vbarua removed PMC Ready PRs ready for review by PMCs awaiting PMC approval labels Mar 5, 2026
@vbarua vbarua merged commit ada68a8 into main Mar 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove deprecated SimpleExtensionURI and extension_uri_reference

4 participants