fix(extensions): add signatures with distribution enum arg for std_dev and variance#1011
Merged
vbarua merged 9 commits intosubstrait-io:mainfrom Mar 24, 2026
Merged
Conversation
nielspardon
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua,
westonpace and
yongchul
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
nielspardon
force-pushed
the
par-stddev-dist
branch
from
8ec63ae to
0877df5
Compare
nielspardon
changed the title
nielspardon
changed the title
Member
|
I'm in support of this change, but think we should wait until #1005 lands to make sure we all agree on the meaning of options / enums. |
yongchul
reviewed
Mar 19, 2026
nielspardon
force-pushed
the
par-stddev-dist
branch
from
5aee2ee to
bd05214
Compare
Member
Author
|
Rebased, resolved conflicts, used the new deprecation syntax. |
yongchul
approved these changes
Mar 20, 2026
Contributor
yongchul
left a comment
yongchul
left a comment
There was a problem hiding this comment.
+1 thank you for incorporating the deprecation path and making this non-breaking change! 😄
nielspardon
force-pushed
the
par-stddev-dist
branch
from
72c5cca to
4e9def0
Compare
Member
Author
|
I merged #1010 and rebased this PR |
nielspardon
changed the title
…and variance BREAKING CHANGE: changes the function signature of existing functions std_dev and variance Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-stddev-dist
branch
from
4e9def0 to
b364972
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Member
Author
|
removed the deprecation of the old function signatures per conversation on Slack |
vbarua
reviewed
Mar 23, 2026
vbarua
reviewed
Mar 23, 2026
vbarua
reviewed
Mar 23, 2026
vbarua
reviewed
Mar 23, 2026
vbarua
reviewed
Mar 23, 2026
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Left a minor suggestions about argument ordering. Want to hear what you think about it, but other than that this looks good to me.
nielspardon
force-pushed
the
par-stddev-dist
branch
from
2c6857a to
62da266
Compare
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-stddev-dist
branch
from
62da266 to
8175a73
Compare
vbarua
approved these changes
Mar 24, 2026
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Changes look good. Thanks for updating thee argument order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the recent clarification around function options vs enum arguments I do believe the
std_devandvariancefunction definitions should change thedistributionfunction to be an enum argument.The
distributionparameter changes the semantic behavior of these functions which is why SQL systems typically model the differentdistributionvalues as distinct functions e.g.STDDEV_SAMPandSTDDEV_POP. Providing thedistributionparameter thus is not optional but required.This PR deprecates the existing function signatures for
std_devandvarianceand adds new signatures that use adistributionenum argument instead of a function option.This PR depends on #1010 whose changes are included in this PR since it uses the new enum argument syntax in the test cases I generated using AI for the two functions.
The main changes for this PR are in the second commit 8ec63ae.