feat(extensions): add large container and date_millis extension types#979
Draft
kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
Draft
feat(extensions): add large container and date_millis extension types#979kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
kadinrabo wants to merge 17 commits intosubstrait-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds type definitions for Arrow types that have a different value range than their Substrait core equivalents. Types only, no functions.
large_containers.yaml: large_string, large_binary, large_list (64-bit offsets)fixed_size_list.yaml: fixed_size_list<value_type, dimension>date_millis.yaml: date stored as milliseconds since epoch (64-bit)Per Arrow's own taxonomy: "if two types have a different range, they are not encodings" and need extension types rather than type variations. https://github.com/apache/arrow/blob/879bbb3677fcde701dfed89c7d9abdf979271fcd/format/substrait/extension_types.yaml#L50-L51
Depends on #953.
This change is